Feature: Channel by channel gain configuration for opdet deconvolution#126
Draft
Feature: Channel by channel gain configuration for opdet deconvolution#126
Conversation
lpaulucc
reviewed
Jan 12, 2026
Member
lpaulucc
left a comment
lpaulucc
left a comment
There was a problem hiding this comment.
It looks good. But should it not have a default value (empty?) for ChannelGainFile when the parameter is read or in the Deconvolution.fcl?
Member
Author
|
@lpaulucc Yes, I was thinking about that. I am inclined to keep the configurable without default, but specify an empty string in the default config fhicl. I'll do this when I get back to it. I still need to implement some undefined-situation handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing feature to allow configuration of gains for each channel in the deconvolution algorithm. The gains are used to normalise the output waveform - the SPE templates' amplitudes are normalised to the specified gain (number of ADCs per SPE).
The gains are expected to come within an ascii file: each row specifies the channel number and the gain, separated by whitespace.
The new configurable for the deconvolution module is
ChannelGainFile. If it is an empty string, no rescaling is done and the SPE amplitude is equal to the amplitude of the corresponding SPE template.So far, no checks are done if all channels have the gain set and it is implicitly assumed that they are. The case where only subset of channels have their gains set would lead to a segfault.